Skip to content

fix: Update codecov dark logo and fix broken invoice img #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Feb 12, 2025

Description

codecov/engineering-team#3069

Screenshots

Screenshot 2025-02-12 at 11 45 04 AM Screenshot 2025-02-12 at 11 45 09 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Feb 12, 2025

Bundle Report

Changes will increase total bundle size by 327 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.26MB 214 bytes (0.0%) ⬆️
gazebo-production-esm 6.31MB 113 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 59 bytes 9.63kB 0.62%
assets/index-legacy.*.js 59 bytes 23.73kB 0.25%
assets/index-legacy.*.js 59 bytes 7.91kB 0.75%
assets/index-legacy.*.js 59 bytes 42.5kB 0.14%
assets/index-legacy.*.js -226 bytes 15.08kB -1.48%
assets/ExpandableSection-legacy.*.js (New) 1.17kB 1.17kB 100.0% 🚀
assets/LightDarkImg-legacy.*.js -961 bytes 347 bytes -73.47%

Files in assets/index-legacy.*.js:

  • ./src/pages/PlanPage/subRoutes/InvoiceDetailsPage/sections/InvoiceHeader.tsx → Total Size: 3.06kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 58 bytes 7.9kB 0.74%
assets/index.*.js -5 bytes 8.62kB -0.06%
assets/index.*.js 5 bytes 9.28kB 0.05%
assets/index.*.js 5 bytes 7.21kB 0.07%
assets/index.*.js 5 bytes 6.47kB 0.08%
assets/index.*.js 5 bytes 37.65kB 0.01%
assets/index.*.js 5 bytes 8.52kB 0.06%
assets/index.*.js 53 bytes 9.39kB 0.57%
assets/index.*.js -5 bytes 51.18kB -0.01%
assets/index.*.js 58 bytes 24.49kB 0.24%
assets/index.*.js -237 bytes 15.32kB -1.52%
assets/index.*.js 58 bytes 45.88kB 0.13%
assets/index.*.js 5 bytes 6.46kB 0.08%
assets/index.*.js -5 bytes 6.26kB -0.08%
assets/usePull.*.js -5 bytes 9.07kB -0.06%
assets/useCommits.*.js -5 bytes 5.49kB -0.09%
assets/CIStatus.*.js 5 bytes 2.61kB 0.19%
assets/RadioTileGroup.*.js -5 bytes 2.12kB -0.23%
assets/ExpandableSection.*.js (New) 1.07kB 1.07kB 100.0% 🚀
assets/LightDarkImg.*.js -956 bytes 258 bytes -78.75%

Files in assets/index.*.js:

  • ./src/pages/PlanPage/subRoutes/InvoiceDetailsPage/sections/InvoiceHeader.tsx → Total Size: 3.06kB

@codecov-staging
Copy link

codecov-staging bot commented Feb 12, 2025

Bundle Report

Changes will increase total bundle size by 327 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.26MB 214 bytes (0.0%) ⬆️
gazebo-staging-esm 6.31MB 113 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 59 bytes 42.5kB 0.14%
assets/index-legacy.*.js 59 bytes 9.63kB 0.62%
assets/index-legacy.*.js -226 bytes 15.08kB -1.48%
assets/index-legacy.*.js 59 bytes 7.91kB 0.75%
assets/index-legacy.*.js 59 bytes 23.73kB 0.25%
assets/ExpandableSection-legacy.*.js (New) 1.17kB 1.17kB 100.0% 🚀
assets/LightDarkImg-legacy.*.js -961 bytes 347 bytes -73.47%

Files in assets/index-legacy.*.js:

  • ./src/pages/PlanPage/subRoutes/InvoiceDetailsPage/sections/InvoiceHeader.tsx → Total Size: 3.06kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 5 bytes 37.65kB 0.01%
assets/index.*.js 5 bytes 6.47kB 0.08%
assets/index.*.js -5 bytes 51.18kB -0.01%
assets/index.*.js 58 bytes 7.9kB 0.74%
assets/index.*.js -237 bytes 15.32kB -1.52%
assets/index.*.js 58 bytes 45.88kB 0.13%
assets/index.*.js 53 bytes 9.39kB 0.57%
assets/index.*.js 5 bytes 9.28kB 0.05%
assets/index.*.js 5 bytes 6.46kB 0.08%
assets/index.*.js 5 bytes 7.21kB 0.07%
assets/index.*.js 5 bytes 8.52kB 0.06%
assets/index.*.js 58 bytes 24.49kB 0.24%
assets/index.*.js -5 bytes 6.26kB -0.08%
assets/index.*.js -5 bytes 8.62kB -0.06%
assets/usePull.*.js -5 bytes 9.07kB -0.06%
assets/useCommits.*.js -5 bytes 5.49kB -0.09%
assets/CIStatus.*.js 5 bytes 2.61kB 0.19%
assets/RadioTileGroup.*.js -5 bytes 2.12kB -0.23%
assets/ExpandableSection.*.js (New) 1.07kB 1.07kB 100.0% 🚀
assets/LightDarkImg.*.js -956 bytes 258 bytes -78.75%

Files in assets/index.*.js:

  • ./src/pages/PlanPage/subRoutes/InvoiceDetailsPage/sections/InvoiceHeader.tsx → Total Size: 3.06kB

@codecov-qa
Copy link

codecov-qa bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (95c655d) to head (88e1f49).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         823      823           
  Lines       14853    14853           
  Branches     4228     4228           
=======================================
  Hits        14682    14682           
  Misses        165      165           
  Partials        6        6           
Files with missing lines Coverage Δ
...utes/InvoiceDetailsPage/sections/InvoiceHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.52% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c655d...88e1f49. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         823      823           
  Lines       14853    14853           
  Branches     4220     4220           
=======================================
  Hits        14682    14682           
  Misses        165      165           
  Partials        6        6           
Files with missing lines Coverage Δ
...utes/InvoiceDetailsPage/sections/InvoiceHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.52% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c655d...88e1f49. Read the comment docs.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (95c655d) to head (88e1f49).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         823      823           
  Lines       14853    14853           
  Branches     4228     4220    -8     
=======================================
  Hits        14682    14682           
  Misses        165      165           
  Partials        6        6           
Files with missing lines Coverage Δ
...utes/InvoiceDetailsPage/sections/InvoiceHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.52% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c655d...88e1f49. Read the comment docs.

Copy link

codecov-public-qa bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (95c655d) to head (88e1f49).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         823      823           
  Lines       14853    14853           
  Branches     4220     4220           
=======================================
  Hits        14682    14682           
  Misses        165      165           
  Partials        6        6           
Files with missing lines Coverage Δ
...utes/InvoiceDetailsPage/sections/InvoiceHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.52% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c655d...88e1f49. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 12, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
854dae2 Wed, 12 Feb 2025 18:05:52 GMT Expired Expired
2e1dc74 Wed, 12 Feb 2025 18:51:37 GMT Expired Expired
b4d8bf9 Wed, 12 Feb 2025 19:23:32 GMT Expired Expired
65cc71f Thu, 13 Feb 2025 02:06:53 GMT Expired Expired
7b7e7e3 Thu, 13 Feb 2025 17:29:19 GMT Expired Expired
96fe32a Thu, 13 Feb 2025 18:06:36 GMT Expired Expired
88e1f49 Thu, 13 Feb 2025 18:52:48 GMT Cloud Enterprise

@calvin-codecov calvin-codecov force-pushed the cy/invoice_codecov_logo branch from 854dae2 to 2e1dc74 Compare February 12, 2025 18:45
@calvin-codecov calvin-codecov changed the title fix: Update codecov logo and fix broken invoice img fix: Update codecov dark logo and fix broken invoice img Feb 12, 2025
alt="Codecov Logo"
src={`${process.env.PUBLIC_URL}/logo.svg`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env.PUBLIC_URL was a CRA construct that we no longer have since moving to vite. We can link to /public in vite with just /

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! TIL about that LightDarkImg component

@calvin-codecov calvin-codecov added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit cb3fe37 Feb 13, 2025
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/invoice_codecov_logo branch February 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants