Skip to content

fix: RepoPage table header having no BG #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: RepoPage table header having no BG #3545

merged 1 commit into from
Dec 3, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

The current header for the repo page code tree/file list has no bg set so it's transparent, which isn't great. This PR is a small fix to resolve it

Notable Changes

  • Add BG to file wrapping sticky header

Screenshots

Before:

Screenshot 2024-12-03 at 10 39 43

After:

Screenshot 2024-12-03 at 10 45 34

@codecov-staging
Copy link

codecov-staging bot commented Dec 3, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 127 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 37 bytes (-0.0%) ⬇️
gazebo-staging-system 5.66MB 90 bytes (-0.0%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024

Bundle Report

Changes will decrease total bundle size by 127 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.66MB 90 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.72MB 37 bytes (-0.0%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3545   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         807      806    -1     
  Lines       14476    14476           
  Branches     4109     4115    +6     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44255e7...e1f585a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (44255e7) to head (e1f585a).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3545   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         807      806    -1     
  Lines       14476    14476           
  Branches     4116     4108    -8     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44255e7...e1f585a. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (44255e7) to head (e1f585a).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3545   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         807      806    -1     
  Lines       14476    14476           
  Branches     4109     4115    +6     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44255e7...e1f585a. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 3, 2024
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
e1f585a Tue, 03 Dec 2024 14:52:25 GMT Cloud Enterprise

Merged via the queue into main with commit a77d790 Dec 3, 2024
61 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-repo-page-table-header-not-having-any-bg branch December 3, 2024 14:54
@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (44255e7) to head (e1f585a).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3545   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         807      806    -1     
  Lines       14476    14476           
  Branches     4109     4115    +6     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44255e7...e1f585a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov @nsdeschenes