Skip to content

fix: Copy update on Cumulative Failure tile #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Nov 18, 2024

Description

This PR just updates some copy on the cumulative failures tile on the failed tests table. Previously we mentioned that the failures shown were for all branches, but its actually just the default branch

Closes codecov/engineering-team#2942

Screenshots

Screenshot 2024-11-18 at 3 55 31 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 18, 2024

Bundle Report

Changes will decrease total bundle size by 494 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 339 bytes (-0.01%) ⬇️
gazebo-production-system-esm 5.61MB 155 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 18, 2024

Bundle Report

Changes will decrease total bundle size by 494 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.61MB 155 bytes (-0.0%) ⬇️
gazebo-staging-system 5.56MB 339 bytes (-0.01%) ⬇️

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (3133f8c) to head (100803a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         806      806           
  Lines       14369    14369           
  Branches     4077     4077           
=======================================
  Hits        14216    14216           
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.60% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...100803a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         806      806           
  Lines       14369    14369           
  Branches     4077     4084    +7     
=======================================
  Hits        14216    14216           
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.60% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...100803a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (3133f8c) to head (100803a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         806      806           
  Lines       14369    14369           
  Branches     4077     4077           
=======================================
  Hits        14216    14216           
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.60% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...100803a. Read the comment docs.


🚨 Try these New Features:

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 19, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
100803a Tue, 19 Nov 2024 00:02:23 GMT Expired Expired
100803a Tue, 19 Nov 2024 00:07:55 GMT Cloud Enterprise

@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit a492dcd Nov 19, 2024
61 of 62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/2942-cumulative-failure-copy-update branch November 19, 2024 00:29
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (3133f8c) to head (100803a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         806      806           
  Lines       14369    14369           
  Branches     4084     4084           
=======================================
  Hits        14216    14216           
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.60% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3133f8c...100803a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI copy for Cumulative Failure
3 participants