Fix : add identifierType=alias in OpsGenieNotifier close URL #4559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @98001yash, any help is much appreciated, but there already it a pull request addressing this issue (see #4557). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When closing alerts in OpsGenie, the API requires the
identifierType=aliasparameter if the alias is used instead of the alert ID.This change updates the
buildUrlmethod inOpsGenieNotifierto append?identifierType=aliaswhen constructing the close alert URL.Changes
buildUrlto ensureidentifierType=aliasis included in the close alert request.Why
Without the
identifierTypeparameter, closing alerts via the OpsGenie API would fail with an error, since the alias is used to identify the alert.References