Chore/minor clean ups 6 #4523
Chore/minor clean ups 6 #4523
Conversation
| this.source = source; | ||
| this.metadata = new LinkedHashMap<>(); | ||
| metadata.forEach(this.metadata::put); | ||
| for (Map.Entry<String, String> entry : metadata.entrySet()) { |
There was a problem hiding this comment.
It should fix possible performance issues with metadata.forEach(this.metadata::put);
There was a problem hiding this comment.
Can you explain why there is a performance issue with the forEach but not with for loop? It is calling the same put method and I don't expect many entries here.
There was a problem hiding this comment.
Having metadata.forEach(this.metadata::put); IntelliJ will complain about possible performance issues and suggest you to use this.metadata.putAll(metadata). If used, this will make a result map immutable and will brake the logic, so for example HazelcastEventStoreTest will go in a never ending loop.
There was a problem hiding this comment.
Ok, so for performance, putAll is better than putting each one separately... but for loop is not better than forEach, it just hides it from IntelliJ?
There was a problem hiding this comment.
Exactly, it prevents possible "small enhancement" braking the code.
No description provided.