chore: remove maven warnings #4434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteKoe
force-pushed
the
refactoring/remove-some-maven-build-warnings
branch
2 times, most recently
from
a18f2bd to
95ef537
Compare
erikpetzold
reviewed
Jul 3, 2025
| import org.springframework.security.web.authentication.SavedRequestAwareAuthenticationSuccessHandler; | ||
| import org.springframework.security.web.csrf.CookieCsrfTokenRepository; | ||
| import org.springframework.security.web.util.matcher.AntPathRequestMatcher; | ||
| import org.springframework.security.web.servlet.util.matcher.PathPatternRequestMatcher; |
There was a problem hiding this comment.
"maven warnings"? Did you mean javacompiler warnings?
There was a problem hiding this comment.
well, yes, but in maven they are printed as "[WARNING] ..."
| PathPatternRequestMatcher.withDefaults().matcher(POST, this.adminServer.path("/instances")), | ||
| PathPatternRequestMatcher.withDefaults() | ||
| .matcher(DELETE, this.adminServer.path("/instances/*")), | ||
| PathPatternRequestMatcher.withDefaults().matcher(this.adminServer.path("/actuator/**")))); |
There was a problem hiding this comment.
I hope we have good tests for this, the matchers made problems in one update I think
There was a problem hiding this comment.
I am not sure, but I guess: no. Hazelcast is an example we should have a look on in a different task anyways.
SteKoe
force-pushed
the
refactoring/remove-some-maven-build-warnings
branch
from
95ef537 to
fd9fa1e
Compare
SteKoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.