[Issue-9] Fix flaky unit test #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mpospese
requested review from
SahilSainiYML,
WestonHanners,
devkaranCT,
karthikyml and
sanjibchakraborty
SahilSainiYML
approved these changes
Mar 14, 2023
devkaranCT
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Recently we've had one flaky unit test that's been acting up. We should fix its behavior.
Purpose
Fix #9 flaky unit test (testing behavior of cancel on background upload request).
Scope
URLProtocolStubNetworkEngineto turn off automatically resuming background tasks immediately after submitting them.Discussion
The download manager cancel test had not (yet) been flaky, but we should probably adopt the same behavior for both tests.
I also set the tests to execute in random order (this should already have been the case).
📈 Coverage
Code
94.4%
Documentation
100%