Skip to content

fix(balances): exempt USDC from balance filtering #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 2 commits into from
Dec 29, 2025
Merged

fix(balances): exempt USDC from balance filtering #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d227d
fix(balances): exempt USDC from balance filtering
raulriera Dec 17, 2025
fe4339c
Update Session.swift
raulriera Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Flipcash/Core/Screens/Main/BalanceScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct BalanceScreen: View {
}

private var usdcBalance: ExchangedBalance? {
balances.first { $0.stored.mint == .usdc }
balances.first { $0.stored.mint == .usdc && $0.stored.quarks > 0 }
}

// MARK: - Init -
Expand Down
4 changes: 2 additions & 2 deletions Flipcash/Core/Session/Session.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ class Session: ObservableObject {
balances.compactMap { stored in
let exchangedFiat = stored.computeExchangedValue(with: rate)

// Filter out balances with zero fiat value after conversion
guard exchangedFiat.hasDisplayableValue() else {
// Filter out balances with zero fiat value after conversion (except for USDC)
guard stored.mint == .usdc || exchangedFiat.hasDisplayableValue() else {
return nil
}

Expand Down
2 changes: 0 additions & 2 deletions FlipcashTests/GiveViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@ struct GiveViewModelTests {

/// Helper to create a test view model
static func createViewModel() -> GiveViewModel {
let isPresented = Binding<Bool>(get: { true }, set: { _ in })
let container = Container.mock
let sessionContainer = SessionContainer.mock

let viewModel = GiveViewModel(
isPresented: isPresented,
container: container,
sessionContainer: sessionContainer
)
Expand Down