Skip to content

Conversation

KashifSaadat
Copy link
Contributor

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
  • Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
  • Have you picked the single best (existing) category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Have you added your SVG to hosted_logos and referenced it there?
  • Does your logo clearly state the name of the project/product and follow the other guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

Copy link

You can preview your changes by visiting this link.

Note

This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

@KashifSaadat KashifSaadat force-pushed the terranetes-controller branch from c7d73d8 to e0d7632 Compare August 13, 2024 14:00
@KashifSaadat
Copy link
Contributor Author

KashifSaadat commented Aug 13, 2024

Question for the maintainers: Is the 300 GitHub stars an absolute requirement for an open source project to be listed? If so, this would not currently be eligible and I'd need to close the PR.

The guidelines mention: Cloud native projects with at least 300 GitHub stars that clearly fit in an existing category are generally included. With the "generally included" wording, it was unclear as to whether it's a strict requirement or not.

Thanks!

@KashifSaadat KashifSaadat force-pushed the terranetes-controller branch from e0d7632 to a4410a8 Compare August 13, 2024 14:45
@KashifSaadat KashifSaadat force-pushed the terranetes-controller branch from a4410a8 to 829f504 Compare August 13, 2024 15:56
@castrojo castrojo added this pull request to the merge queue Aug 16, 2024
Merged via the queue into cncf:master with commit aada20a Aug 16, 2024
3 checks passed
@rohail0346khan rohail0346khan mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants