feat: Trigger other Benchmark workflows #106
Conversation
|
Only place left for testing this script is workflow_dispatch with 2 types of workflows which can have sub_components or not have it also need to think of do we send one sub_component at a time or all at once like a json array or a string with each having its individual workflow_call? |
There was a problem hiding this comment.
@dipankardas011 Thank you the approach here using bash works a lot better.
Some changes still needed. Especially the output to the console which can be much simpler.
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
dipankardas011
force-pushed
the
98-release-trigger-dispatcher
branch
from
9117386 to
0eb55bc
Compare
Signed-off-by: Dipankar Das <[email protected]>
dipankardas011
changed the title
Signed-off-by: Dipankar Das <[email protected]>
|
@rossf7 Should I add color for error and success logs? |
There was a problem hiding this comment.
@rossf7 Should I add color for error and success logs?
@dipankardas011 No that isn't necessary and makes the code more complex.
Pls revert the changes in 129d110
Better to focus on making sure the text in the echo statements is clear. I suggested a couple of edits and then this is good to go
Signed-off-by: Dipankar Das <[email protected]>
dipankardas011
force-pushed
the
98-release-trigger-dispatcher
branch
from
129d110 to
5ec943c
Compare
But the env var for the gh_pat token? |
@dipankardas011 We need to open a service desk ticket to request a new token. I'll take care but will need some help from the other leads. |
|
@dipankardas011 Token is added as a secret and working well here. Nice job! 🚀 There is an issue with the deploy step itself. Will debug that later |
* feat: bash script to trigger other workflow files Signed-off-by: Dipankar Das <[email protected]> * added error handling Signed-off-by: Dipankar Das <[email protected]> * added temporary error handling of ghtoken escape Signed-off-by: Dipankar Das <[email protected]> * improved the curl requests Signed-off-by: Dipankar Das <[email protected]> * updated the final reviewd codebase Signed-off-by: Dipankar Das <[email protected]> * Updated the dispatch file name Signed-off-by: Dipankar Das <[email protected]> * updated the logging Signed-off-by: Dipankar Das <[email protected]> * added the handling of sub_components Signed-off-by: Dipankar Das <[email protected]> * fix the workflow_dispatch Signed-off-by: Dipankar Das <[email protected]> * improved the logging Signed-off-by: Dipankar Das <[email protected]> --------- Signed-off-by: Dipankar Das <[email protected]>
What type of PR is this?
kind/feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer (optional):