Refactor apply_forcefield #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #55 and a comment in there. This opens up the
_apply_forcefield
and rather than it being called automatically inside ofSystem.__init__
is has to be called manually. The forcefield related parameters are moved out ofSystem.__init__
and intoapply_forcefield
and the PPPM arguments are added.@marjanAlbouye and I have gone back and forth between thinking about how the
appy_forcefield
method should be handled, so let me know what you think and if you recognize any issues that might pop up from these changes.