Skip to content

Minor code style improvements #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 1 commit into from
Sep 2, 2018
Merged

Minor code style improvements #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Readline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

namespace Clue\React\Stdio;

use Clue\React\Term\ControlCodeParser;
use Clue\React\Utf8\Sequencer as Utf8Sequencer;
use Evenement\EventEmitter;
use React\Stream\ReadableStreamInterface;
use React\Stream\WritableStreamInterface;
use React\Stream\Util;
use Clue\React\Utf8\Sequencer as Utf8Sequencer;
use Clue\React\Term\ControlCodeParser;
use React\Stream\WritableStreamInterface;

class Readline extends EventEmitter implements ReadableStreamInterface
{
Expand Down Expand Up @@ -37,7 +37,8 @@ public function __construct(ReadableStreamInterface $input, WritableStreamInterf
$this->output = $output;

if (!$this->input->isReadable()) {
return $this->close();
$this->close();
return;
}
// push input through control code parser
$parser = new ControlCodeParser($input);
Expand Down Expand Up @@ -411,7 +412,7 @@ public function listHistory()
*/
public function limitHistory($limit)
{
$this->historyLimit = $limit === null ? null : (int)$limit;
$this->historyLimit = $limit === null ? null : $limit;

// limit send and currently exceeded
if ($this->historyLimit !== null && isset($this->historyLines[$this->historyLimit])) {
Expand Down Expand Up @@ -441,9 +442,8 @@ public function limitHistory($limit)
*
* @param callable|null $autocomplete
* @return self
* @throws InvalidArgumentException if the given callable is invalid
* @throws \InvalidArgumentException if the given callable is invalid
*/

public function setAutocomplete($autocomplete)
{
if ($autocomplete !== null && !is_callable($autocomplete)) {
Expand Down
2 changes: 1 addition & 1 deletion tests/FunctionalExampleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function testPeriodicExampleWithClosedInputQuitsImmediately()

public function testPeriodicExampleWithClosedInputAndOutputQuitsImmediatelyWithoutOutput()
{
$output = $this->execExample('php 01-periodic.php <&- >&- 2>&1');
$output = $this->execExample('php 01-periodic.php <&- >&- 2>&-');

if (strpos($output, 'said') !== false) {
$this->markTestIncomplete('Your platform exhibits a closed STDIN bug, this may need some further debugging');
Expand Down