Add commit API endpoint #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
friendly reminder 😄 |
clue
reviewed
Feb 15, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@dinooo13 Thank you for looking into this and providing this high-quality PR, much appreciated! 👍
The containerCommit() API name is interesting, given the API docs use "ImageCommit" ("Create a new image from a container") and the API endpoint and docker CLI command are both named just "commit". What do you think about this?
Also noticed two minor issues below, can you look into this?
Keep it up! 👍
Keep it up! 👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @clue this is my first try at a contribution, I hope it's any good.