TTY resize request should use POST #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1.15 API documention describes this as a GET request, which always appeared strange. I've tested this against the v1.15 API and can confirm this should have been a POST request ever since. The API documentation has been updated as of v1.16, but does not mention this fix at all.
https://docs.docker.com/engine/reference/api/docker_remote_api_v1.15/#resize-a-container-tty
https://docs.docker.com/engine/reference/api/docker_remote_api_v1.16/#resize-a-container-tty
https://docs.docker.com/engine/reference/api/docker_remote_api/#v1-16-api-changes
https://github.com/docker/docker-py/blob/fdd118706a1e63cc22821e6610cfd861eca1f7b9/docker/api/container.py#L287