Skip to content

Move from private to protected for extensibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jom wants to merge 1 commit into from
Closed

Move from private to protected for extensibility #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
*/
class Client
{
private $browser;
private $parser;
private $streamingParser;
protected $browser;
protected $parser;
protected $streamingParser;

/**
* Instantiate new Client
Expand Down Expand Up @@ -858,15 +858,15 @@ public function execResize($exec, $w, $h)
)->then(array($this->parser, 'expectEmpty'));
}

private function postJson($url, $data)
protected function postJson($url, $data)
{
$body = $this->json($data);
$headers = array('Content-Type' => 'application/json', 'Content-Length' => strlen($body));

return $this->browser->post($url, $headers, $body);
}

private function json($data)
protected function json($data)
{
if ($data === array()) {
return '{}';
Expand Down Expand Up @@ -897,7 +897,7 @@ private function json($data)
* @link https://docs.docker.com/reference/api/docker_remote_api/ for details about the AuthConfig object
* @link https://github.com/docker/docker/issues/9315 for error description
*/
private function authHeaders($registryAuth)
protected function authHeaders($registryAuth)
{
$headers = array();
if ($registryAuth !== null) {
Expand All @@ -914,7 +914,7 @@ private function authHeaders($registryAuth)
* @return int|null returns the integer `1` for boolean true values and a `null` for boolean false values
* @see Browser::resolve()
*/
private function boolArg($value)
protected function boolArg($value)
{
return ($value ? 1 : null);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

class Factory
{
private $loop;
private $browser;
protected $loop;
protected $browser;

public function __construct(LoopInterface $loop, Browser $browser = null)
{
Expand Down