Add support for throwables (>= PHP 7.0), not throwing UnexpectedValueException anymore #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose the change to support Throwables next to Exceptions, so that they can be handled properly as well.
Throwables within PHP are supported since PHP 7.0. Currently only Exceptions are supported and Throwables will lead to an UnexpectedValueException. With this change Throwables are supported as well.
Given the direction reactphp/promise goes I think it would be good to make this change.