fix:add batchSize to semantic embedStrings #224 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| end = total | ||
| } | ||
|
|
||
| batch := combinedSentences[start:end] |
There was a problem hiding this comment.
这样处理会影响效果，目前主流 embedding 会嵌入句子间的联系，分批嵌入会影响下边计算的准确性。 这里我更倾向于用户使用其他split 方法先把输入切分成 embedding 支持的范围内再使用 semtic splitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为 semantic splitter 组件增加 batchSize 配置
作用： 使组件进行 embedStrings 操作时，不超出batchSize，以通过部分API提供商的批量最大值限制