feat: Add default base URL for Ollama #158
Conversation
|
|
| @@ -37,8 +38,8 @@ var CallbackMetricsExtraKey = "ollama_metrics" | |||
|
|
|||
| // ChatModelConfig stores configuration options specific to Ollama | |||
| type ChatModelConfig struct { | |||
| BaseURL string `json:"base_url"` | |||
| Timeout time.Duration `json:"timeout"` // request timeout for http client | |||
| BaseURL string `json:"base_url"` // optional, host can be configured via the OLLAMA_HOST environment variable otherwise default is http://localhost:11434 | |||
There was a problem hiding this comment.
Ollama provides an initialization function, api.ClientFromEnvironment(), which retrieves the host from environment variables. However, as a component, it still requires initialization before use. The additional support for retrieving values from environment variables doesn’t seem to offer much convenience
There was a problem hiding this comment.
If you are using the default Ollama host or have already set the OLLAMA_HOST environment variable, there is no need to specify BaseURL when using ChatModelConfig. You only need to set BaseURL if you are using a non-default Ollama host and have not set the OLLAMA_HOST environment variable.
There was a problem hiding this comment.
my option is that we could call api.ClientFromEnvironment() to create client when base_url is empty instead of manually reading envconfig.Host() to set base_url
What type of PR is this?
According to Ollama's API doc we should be able to set the default base URL to
http://localhost:11434.Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: