-
Notifications
You must be signed in to change notification settings - Fork 36
feat: move definition of AST as independent module and refactor some structures #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "path/filepath" | ||
| "strings" | ||
|
|
||
| . "github.com/cloudwego/abcoder/src/uniast" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个副作用 import 的目的是啥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
引入 pub struct 吗?带上前缀的方式可能会清晰一些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就不用到处引用都得加上uniast.了。。。改动有点大
What type of PR is this?
Check the PR title.
refactor
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: