Skip to content

Conversation

@AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Mar 7, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo
    refactor

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

"path/filepath"
"strings"

. "github.com/cloudwego/abcoder/src/uniast"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个副作用 import 的目的是啥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

引入 pub struct 吗?带上前缀的方式可能会清晰一些?

Copy link
Collaborator Author

@AsterDY AsterDY Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就不用到处引用都得加上uniast.了。。。改动有点大

@AsterDY AsterDY changed the title feat: move definition of AST as independent module feat: move definition of AST as independent module and refactor some structures Mar 21, 2025
@AsterDY AsterDY merged commit e01828a into main Mar 24, 2025
2 checks passed
@AsterDY AsterDY deleted the feat/iterator branch April 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants