feat: support both relative & absolute path in config #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkeyever
force-pushed
the
fix/cmd_cwd_bug
branch
from
c7b8b4b to
2fc47c1
Compare
AsterDY
reviewed
Mar 5, 2025
| // get current directory | ||
| let output = Command::new(cmd) | ||
| .args(args) | ||
| .current_dir(env::current_dir()?.to_str().unwrap()) |
Member
Author
There was a problem hiding this comment.
这个 cwd 默认和父进程保持一致就行 & 执行命令的 path 统一在收敛在最外面计算（基于 CONFIG 中的字段），统一管理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional): 1. config 同时支持相对路径和绝对路径；2. 增加一个 WORK_DIR 作为所有相对路径的 base，方便在多个 workspace 之间快速切换；3. 开箱即用：即使.env 文件缺省，default 配置保证解析阶段正常工作（compress 阶段要求LLM token，这个无法做到完全的无配置运行）
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: