bugfix: validation and null countUnit #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
goruha
approved these changes
Jul 25, 2025
|
/terratest |
|
These changes were released in v0.43.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the handling of custom lifecycle rules in Terraform configurations by improving validation logic and enhancing the selection merging process. The changes aim to make the code more robust and handle edge cases more effectively.
Improvements to selection merging logic:
main.tf: Theselectionmerging logic now includes a check to ensure thatcountUnitis only added if it is not null, and the filtering logic for keys liketagPrefixListandtagPatternListhas been updated to handle null values more gracefully. (main.tf, main.tfL140-R152)Refinements to validation logic:
tagStatusinvariables.tf: Updated the condition to uselength(coalesce(...))for checkingtagPrefixListandtagPatternList, ensuring proper handling of null or empty lists. (variables.tf, variables.tfL163-R163)countTypeinvariables.tf: Adjusted the condition to ensure thatcountUnitis specified whencountTypeissinceImagePushed, with a clearer error message for improved readability. (variables.tf, variables.tfL193-R195)