More resilient droplet upload #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cc-uploader process did not have a draining mechanism. When the process was stopped, any ongoing droplet uploads were aborted immediately, leading to potential failures and incomplete uploads.
This PR introduces a graceful shutdown mechanism to allow ongoing uploads to complete before termination. The key enhancements include:
SIGINT
,SIGTERM
) and responds by allowing uploads to finish before exiting.WaitGroup
(uploadWaitGroup
) is introduced to track ongoing uploads, incremented when a new droplet upload begins and decremented when it completes.Upon receiving a shutdown signal, cc-uploader will:
1 Log the shutdown event.
2 Wait for all active uploads to complete using the uploadWaitGroup.
3 Gracefully shut down the HTTP servers (TLS and non-TLS).
Uses http.Server.Shutdown with a timeout to gracefully close both TLS and non-TLS servers.
Code Changes
signalChan
to capture termination signals.uploadWaitGroup
ensurescc-uploader
waits for all uploads to finish before stopping.Add draining for cc_uploader capi-release#529
Add draining for cc uploader cloud_controller_ng#4296