-
Couldn't load subscription status.
- Fork 1k
fix: assets only versions upload should include tag and message #9917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "wrangler": patch | ||
| --- | ||
|
|
||
| fix: assets only versions upload should include tag and message | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -596,6 +596,62 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)( | |
| `); | ||
| }); | ||
|
|
||
| it("should upload version of Worker with assets only", async () => { | ||
| await helper.seed({ | ||
| "wrangler.toml": dedent` | ||
| name = "${workerName}" | ||
| compatibility_date = "2023-01-01" | ||
|
|
||
| [assets] | ||
| directory = "./public" | ||
| `, | ||
| "public/asset.txt": `beep boop beep boop`, | ||
| "package.json": dedent` | ||
| { | ||
| "name": "${workerName}", | ||
| "version": "0.0.0", | ||
| "private": true | ||
| } | ||
| `, | ||
| }); | ||
|
|
||
| const upload = await helper.run( | ||
| `wrangler versions upload --message "Upload via e2e test" --tag "e2e-upload-assets"` | ||
| ); | ||
|
|
||
| expect(normalize(upload.stdout)).toMatchInlineSnapshot(` | ||
| "🌀 Building list of assets... | ||
| ✨ Read 1 file from the assets directory /tmpdir | ||
| 🌀 Starting asset upload... | ||
| 🌀 Found 1 new or modified static asset to upload. Proceeding with upload... | ||
| + /asset.txt | ||
| Uploaded 1 of 1 assets | ||
| ✨ Success! Uploaded 1 file (TIMINGS) | ||
| Total Upload: xx KiB / gzip: xx KiB | ||
| Worker Startup Time: (TIMINGS) | ||
| Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS) | ||
| Worker Version ID: 00000000-0000-0000-0000-000000000000 | ||
| Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev | ||
| To deploy this version to production traffic use the command wrangler versions deploy | ||
| Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy | ||
| Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy" | ||
| `); | ||
|
|
||
| const versionsView = await helper.run( | ||
| `wrangler versions view ${matchVersionId(upload.stdout)}` | ||
| ); | ||
| expect(normalize(versionsView.stdout)).toMatchInlineSnapshot(` | ||
| "Version ID: 00000000-0000-0000-0000-000000000000 | ||
| Created: TIMESTAMP | ||
| Author: [email protected] | ||
| Source: Unknown (version_upload) | ||
| Tag: e2e-upload-assets | ||
| Message: Upload via e2e test | ||
| ------------------------------------------------------------ | ||
| Compatibility Date: 2023-01-01" | ||
| `); | ||
| }); | ||
|
|
||
| it("should include version preview url in output file", async () => { | ||
| const outputFile = path.join(helper.tmpPath, "output.jsonnd"); | ||
| const upload = await helper.run( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just as an FYI, this will also support preview aliases (new!) since they're uploaded in version annotations)