[wrangler] fix: change wrangler (pages) dev to listen on localhost by default
#4532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require `MF-Op-Secret` header to match `MINIFLARE_PROXY_SECRET` data binding before request processed.
🦋 Changeset detectedLatest commit: 0967ebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1000hz
approved these changes
Nov 30, 2023
|
A create-cloudflare (C3) prerelease is available for testing. npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs//npm-package-create-cloudflare-Note that these links will no longer work once the GitHub Actions artifact expires. |
lrapoport-cf
approved these changes
Nov 30, 2023
WalshyDev
approved these changes
Nov 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4532 +/- ##
==========================================
+ Coverage 75.25% 75.33% +0.07%
==========================================
Files 226 226
Lines 12570 12570
Branches 3261 3261
==========================================
+ Hits 9460 9469 +9
+ Misses 3110 3101 -9
|
Merged
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4239.
What this PR solves / how to test:
Previously, Wrangler listened on all interfaces (
*) by default. This change switcheswrangler (pages) devto just listen on local interfaces. Whilst this is technically a breaking change, we've decided the security benefits outweigh the potential disruption caused. If you need to access your dev server from another device on your network, you can usewrangler (pages) dev --ip *to restore the previous behaviour. To test, runwrangler devandlsof -nPiTCP -sTCP:LISTEN. Observe Wrangler isn't listening on all interfaces.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.