Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Nov 21, 2025

This PR adds a pnpm-filters arg to filter what packages are installed in .github/actions/install-dependencies/action.yml

When the action is used by some workflow we would only installed the required packages which should save some time/bw.


  • Tests
    • Tests included
    • Tests not necessary because: ci
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ci
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: ci

@vicb vicb requested a review from a team as a code owner November 21, 2025 10:20
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 4ecbf59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 21, 2025
@vicb vicb marked this pull request as draft November 21, 2025 10:21
@vicb vicb force-pushed the vicb/fast-ci branch 3 times, most recently from 14a6d64 to fc45a63 Compare November 21, 2025 12:27
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11372

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11372

miniflare

npm i https://pkg.pr.new/miniflare@11372

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11372

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11372

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11372

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11372

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11372

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11372

wrangler

npm i https://pkg.pr.new/wrangler@11372

commit: 4ecbf59

turbo-token: ${{ secrets.TURBO_TOKEN }}
turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}

- name: List changed files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving this closer to where it is used and only if needed

@vicb vicb changed the title refactor: make CI do less unneeded steps refactor: make CI do less unneeded work Nov 21, 2025
@vicb vicb marked this pull request as ready for review November 21, 2025 13:01
- name: Install Dependencies
uses: ./.github/actions/install-dependencies
with:
pnpm-filters: "./packages/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need tools as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see .github/prereleases/upload.mjs used.

We should probably move this to the tools as a follow up.
It would also be nice to make sure tools declate all of its deps so that we don't have to install the root package, another follow up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll guess we'll notice sooner rather than later.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are changing this. Don't get-changed-files and paths-filter more or less do the same thing? Could we get by only using one of them?

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 21, 2025
@vicb
Copy link
Contributor Author

vicb commented Nov 21, 2025

Given that we are changing this. Don't get-changed-files and paths-filter more or less do the same thing? Could we get by only using one of them?

get-changed-files generates a list, so we would have to have some script to generate a boolean. Not sure it's worth it?

@vicb
Copy link
Contributor Author

vicb commented Nov 21, 2025

Thanks for the review Pete!

@vicb vicb merged commit 5c0c611 into main Nov 21, 2025
34 checks passed
@vicb vicb deleted the vicb/fast-ci branch November 21, 2025 13:12
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants