-
Notifications
You must be signed in to change notification settings - Fork 1k
Rate limit r2 bulk put #11367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limit r2 bulk put #11367
Conversation
🦋 Changeset detectedLatest commit: 9a2a516 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution.
Does this mean, though, that this approach is fundamentally constrained to be blocked for 5 mins on scenarios where there are more than 5000 files to be cached?
yes, more than 1200 remote objects actually, unfortunately (edit: still faster than 1 object/s without bulking but we probably need to improve that) |
7920ba0 to
9a2a516
Compare
r2 bulk putis based on the Cloudflare API which is rate limitedMake sure we do not exceed the limit when bulk uploading to R2