Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Oct 18, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2297

In the vite plugin, for both vite dev and vite preview make sure that if an account_id is present in the wrangler config file than that account id is used for the remote bindings session.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is fixing an expected behavior
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2025

🦋 Changeset detected

Latest commit: 148ec20

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11009

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11009

miniflare

npm i https://pkg.pr.new/miniflare@11009

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11009

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11009

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11009

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11009

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11009

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11009

wrangler

npm i https://pkg.pr.new/wrangler@11009

commit: 148ec20

@dario-piotrowicz dario-piotrowicz force-pushed the dario/remote-bindings-preview-account-id branch from d7f3110 to b78ac84 Compare October 19, 2025 16:26
@dario-piotrowicz dario-piotrowicz force-pushed the dario/remote-bindings-preview-account-id branch from 4855910 to 8176b3e Compare November 10, 2025 11:30
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 10, 2025 11:34
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners November 10, 2025 11:34
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 13, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/remote-bindings-preview-account-id branch from 803d94d to 449200f Compare November 14, 2025 02:08
@petebacondarwin petebacondarwin force-pushed the dario/remote-bindings-preview-account-id branch 5 times, most recently from a416940 to 31db406 Compare November 20, 2025 16:44
@petebacondarwin petebacondarwin force-pushed the dario/remote-bindings-preview-account-id branch from c995f17 to 148ec20 Compare November 21, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants