-
Notifications
You must be signed in to change notification settings - Fork 1k
In vite dev make sure that the account_id present in the user's config file is used for remote bindings
#11009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dario-piotrowicz
wants to merge
8
commits into
main
Choose a base branch
from
dario/remote-bindings-preview-account-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 148ec20 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
d7f3110 to
b78ac84
Compare
4855910 to
8176b3e
Compare
petebacondarwin
approved these changes
Nov 13, 2025
...s/vite-plugin-cloudflare/e2e/fixtures/remote-bindings-config-account-id/tsconfig.worker.json
Outdated
Show resolved
Hide resolved
803d94d to
449200f
Compare
a416940 to
31db406
Compare
…onfig file is used for remote bindings
Co-authored-by: Pete Bacon Darwin <[email protected]>
c995f17 to
148ec20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-2297
In the vite plugin, for both
vite devandvite previewmake sure that if anaccount_idis present in the wrangler config file than that account id is used for the remote bindings session.