feat: respect CLOUDFLARE_ENV as a fallback for --env #10940
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates Wrangler's CLI parser to recognize the 'CLOUDFLARE_ENV' environment variable. If the '--env' flag is not specified in a command, Wrangler will now use the value of 'CLOUDFLARE_ENV' to determine the target environment. This improves user experience in CI/CD pipelines and local development where setting an environment variable is often more convenient than appending a flag to every command. The '--env' flag continues to take precedence if provided. Key changes include: - A yargs middleware was added to 'createCLIParser' in 'index.ts' to inject the value from 'process.env.CLOUDFLARE_ENV'. - The logic in 'register-yargs-command.ts' that warns about missing environments has been updated to be aware of 'CLOUDFLARE_ENV', preventing false-positive warnings. - Unit tests have been added to 'cli.test.ts' to verify the fallback and override behavior. - 'turbo.json' was updated to include 'CLOUDFLARE_ENV' in 'globalEnv' to ensure correct build caching. Fixes cloudflare#10891
🦋 Changeset detectedLatest commit: feaf356 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates Wrangler's CLI parser to recognize the
'CLOUDFLARE_ENV'environment variable. If the'--env'flag is not specified in a command, Wrangler will now use the value of'CLOUDFLARE_ENV'to determine the target environment.This improves user experience in CI/CD pipelines and local development where setting an environment variable is often more convenient than appending a flag to every command. The
'--env'flag continues to take precedence if provided.Key changes include:
'createCLIParser'in'index.ts'to inject the value from'process.env.CLOUDFLARE_ENV'.'register-yargs-command.ts'that warns about missing environments has been updated to be aware of'CLOUDFLARE_ENV', preventing false-positive warnings.'cli.test.ts'to verify the fallback and override behavior.'turbo.json'was updated to include'CLOUDFLARE_ENV'in'globalEnv'to ensure correct build caching.Fixes #10928