wrangler: feat: wrangler preview_urls default to workers_dev #10939
+317
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d56f5d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
6 tasks
Originally, we were defaulting config.preview_urls to `true`, but we were accidentally enabling Preview URLs for users that only had config.workers_dev=false. Then, we set the default value of config.preview_urls to `false`, but we were accidentally disabling Preview URLs for users that only had config.workers_dev=true. Rather than defaulting config.preview_urls to `true` or `false`, we default to the resolved value of config.workers_dev. Should result in a clearer user experience.
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-to-workers-dev
branch
from
4639ec6 to
fd6d822
Compare
|
Instead of resolving the value of config.preview_urls in Wrangler, let the API decide what the default value is.
danielrs
force-pushed
the
drivas/wrangler-preview-urls-default-to-workers-dev
branch
from
4ca8192 to
4d56f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10722.
Also tracked internally: https://jira.cfdata.org/browse/WC-4085.
Describe your change...
Originally, we were defaulting config.preview_urls to
true, but we were accidentally enabling Preview URLs for users that only had config.workers_dev=false.Then, we set the default value of config.preview_urls to
false, but we were accidentally disabling Preview URLs for users that only had config.workers_dev=true.Rather than defaulting config.preview_urls to
trueorfalse, we default to the resolved value of config.workers_dev. Should result in a clearer user experience.