Skip to content

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Oct 9, 2025

Too many internal details are involved to give an effective summary, but suffice to say that wrangler dev --remote has been broken against Cloudflare Access protected domains for a few weeks. This PR fixes that by adding Access tokens to more requests made during a wrangler dev --remote session.


  • Tests
    • Tests included
    • Tests not necessary because: This involves Cloudflare Access and so needs to be manually verified. In theory we could add an E2E test for this, but given the current length and flakiness of the suite I'm hesitant to do that. @penalosa has manually verified this fixes the issue against a test Access application.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because:

Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: 076e78c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 9, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10938

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10938

miniflare

npm i https://pkg.pr.new/miniflare@10938

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10938

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10938

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10938

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10938

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10938

wrangler

npm i https://pkg.pr.new/wrangler@10938

commit: 076e78c

Copy link

@JoaquinGimenez1 JoaquinGimenez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 10, 2025
@vicb vicb marked this pull request as ready for review October 10, 2025 16:06
@vicb vicb requested a review from a team as a code owner October 10, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

3 participants