fix(vite-plugin-cloudflare): request cancellation support #10707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 176b4ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edmundhung
force-pushed
the
edmundhung/vite-request-cancellation
branch
2 times, most recently
from
6ae710f to
00eafd5
Compare
edmundhung
force-pushed
the
edmundhung/vite-request-cancellation
branch
from
00eafd5 to
160026a
Compare
edmundhung
commented
Sep 22, 2025
Comment on lines
+62
to
+65
| if (request.signal.aborted) { | ||
| // If the request was aborted, ignore the error | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is no avoid vite dev server from rendering an error overlay when the request is aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DEVX-2115
Close #10434.
The fix was originally submitted by @zshannon in #10434. But I am unable to push the tests and changeset to the PR because of the use of default branch there.