fix: re-push image even when only the dockerfile has changed

[emily-shen]

Fixes CC-5563

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: new

[changeset-bot]

🦋 Changeset detected

Latest commit: b84b753

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/dockerfile-change might be a good starting point.

Notes:

• your PR branch should be named v3-backport-10248
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10248

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10248

miniflare

npm i https://pkg.pr.new/miniflare@10248

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10248

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10248

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10248

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10248

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10248

wrangler

npm i https://pkg.pr.new/wrangler@10248

commit: b84b753

[emily-shen]

argh - hoped github might've preserved the changes when i renamed this file. basically this is the same as the original, except i wanted to add some e2e tests for this image re-pushing behaviour since the docker command we use is experimental and could break under us. although i did simplify some of the dev test setup while i was there too.

[emily-shen]

For posterity, I've ended up removing the e2e tests that check this behaviour because I can't get them to work in CI :( (regular unit tests still exist for this feature, the e2e tests worked locally too fwiw...)

I think this is ok because I added the e2e tests because i thought it would be useful to test the actual behaviour of docker manifest inspect since that was experimental, but we don't control the docker version in github CI anyway (e.g. currently the runners are using a version from March still). Also, if the command breaks, it doesn't break anyone's flow, it just means slightly worse DX as there is an unnecessary push.