Skip to content

recommend DOCKER_HOST instead #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

recommend DOCKER_HOST instead #10097

merged 1 commit into from
Jul 28, 2025

Conversation

emily-shen
Copy link
Contributor

tiny followup to #10061 where we add DOCKER_HOST.


  • Tests
    • Tests included
    • Tests not necessary because: error message update
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: error message update
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: new feature

@emily-shen emily-shen requested a review from a team as a code owner July 28, 2025 09:48
Copy link

changeset-bot bot commented Jul 28, 2025

⚠️ No Changeset found

Latest commit: 9d3b2d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 28, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10097

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10097

miniflare

npm i https://pkg.pr.new/miniflare@10097

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10097

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10097

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10097

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10097

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10097

wrangler

npm i https://pkg.pr.new/wrangler@10097

commit: 9d3b2d3

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As a follow up, we should add DOCKER_BIN on top of WRANGLER_DOCKER_BIN

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 28, 2025
@emily-shen emily-shen merged commit 75640c1 into main Jul 28, 2025
65 of 73 checks passed
@emily-shen emily-shen deleted the emily/socket-update branch July 28, 2025 15:31
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants