Skip to content

In deploy config diffs use resolved local config #10377

@dario-piotrowicz

Description

@dario-piotrowicz

#10314 introduced a diffing mechanism that compares the local user authored wrangler config file with the remote representation of the worker's configuration.

There are however a few issues in using the user authored wrangler config for such diffing logic:

  • some fields not present in the file can be resolved to different values (e.g. workers_dev or the worker' name when targeting an environment)
  • if the deployment targets a specific environment then the local config file won't be comparable with the local remote configuration (which does target a specific environment)
  • resolved default values that will be deployed (thus will appear in the remote config on the next check) need to be ignored
  • it is difficult to make this logic format independent (e.g. if a toml file is used ad-hoc logic would need to be introduced to handle it, or (as is currently done) the representation will still be json anyways)

For the reasons above it would be better if we updated the diffing logic so that the resolved local config is used instead.

Naturally this should also be clearly conveyed to users.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

Untriaged

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions