Skip to content

Conversation

ObsidianMinor
Copy link
Contributor

Lots of disconnects in here.

@ObsidianMinor ObsidianMinor requested review from a team as code owners July 15, 2025 02:31
Copy link

codspeed-hq bot commented Jul 15, 2025

CodSpeed Performance Report

Merging #4533 will degrade performances by 45.58%

Comparing fix/actor-cache-delete-all-error (73d2668) with main (249523f)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
SlowAPIWithLock[FastMethodFixture] 94 ms 172.7 ms -45.58%

@ObsidianMinor ObsidianMinor merged commit 4a930eb into main Jul 15, 2025
20 of 21 checks passed
@ObsidianMinor ObsidianMinor deleted the fix/actor-cache-delete-all-error branch July 15, 2025 14:16
@kentonv
Copy link
Member

kentonv commented Jul 16, 2025

Can we please get review from the Durable Objects team on things like this?

I think we should not be seeing disconnects here as disconnects should have been retried upstream. DOs in general should not be getting reset due to disconnecting from storage, so this is actually a bug that should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants