-
Notifications
You must be signed in to change notification settings - Fork 433
Python Workflows API improvements #4470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f271187
to
c37e6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions/comments, but overall looks good
c5e7b55
to
ef478e6
Compare
Do you have any auto linting going into each of these PRs? I do not think it's the scope of this PR to solve it, but I think it would be good to format these with Black, Ruff (Flake8) Sometimes you see things like this all in one project:
|
src/workerd/server/tests/python/workflow-entrypoint/workflow.py
Outdated
Show resolved
Hide resolved
We use the |
0bc312e
to
b50371b
Compare
memoize steps for dependency resolution
b50371b
to
d8a40eb
Compare
This PR includes breaking changes on the
step
API. Workflows are still experimental and under active developmentstep.do
to await for Js promise rejection