Skip to content

Conversation

Caio-Nogueira
Copy link
Contributor

This PR includes breaking changes on the step API. Workflows are still experimental and under active development

  • bugfix step.do to await for Js promise rejection
  • new error translation layer between Python exceptions and Js errors (for now custom exceptions won't be catchable)
  • new DAG optional params - users are now able to define a list of dependencies (other steps they depend on) and have them be executed (in parallel or sequentially). See this diff
  • removes the option to call a step with a callable as the second param - makes the API more uniform
  • adds coverage for these additions in the existing test

@Caio-Nogueira Caio-Nogueira requested review from dom96 and a team July 7, 2025 17:02
@Caio-Nogueira Caio-Nogueira requested review from a team as code owners July 7, 2025 17:02
@Caio-Nogueira Caio-Nogueira force-pushed the caio/python-workflows-2 branch 4 times, most recently from f271187 to c37e6af Compare July 7, 2025 17:36
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions/comments, but overall looks good

@Caio-Nogueira Caio-Nogueira force-pushed the caio/python-workflows-2 branch 2 times, most recently from c5e7b55 to ef478e6 Compare July 8, 2025 15:28
@Talador12
Copy link

Do you have any auto linting going into each of these PRs? I do not think it's the scope of this PR to solve it, but I think it would be good to format these with Black, Ruff (Flake8)

Sometimes you see things like this all in one project:

black
pyright
isort
ssort
darglint
pydocstyle
ruff

@Caio-Nogueira
Copy link
Contributor Author

Do you have any auto linting going into each of these PRs? I do not think it's the scope of this PR to solve it, but I think it would be good to format these with Black, Ruff (Flake8)

Sometimes you see things like this all in one project:

black
pyright
isort
ssort
darglint
pydocstyle
ruff

We use the ruff linter/formatter

@Caio-Nogueira Caio-Nogueira force-pushed the caio/python-workflows-2 branch 2 times, most recently from 0bc312e to b50371b Compare July 9, 2025 15:46
memoize steps for dependency resolution
@Caio-Nogueira Caio-Nogueira force-pushed the caio/python-workflows-2 branch from b50371b to d8a40eb Compare July 10, 2025 14:27
@Caio-Nogueira Caio-Nogueira merged commit b10809c into main Jul 10, 2025
21 checks passed
@Caio-Nogueira Caio-Nogueira deleted the caio/python-workflows-2 branch July 10, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants