Internal Build: Handle forks from Cloudflare org members #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ketanhwr
force-pushed
the
ketan/internal-build
branch
from
de35e81 to
a918b83
Compare
npaun
reviewed
Jun 30, 2025
npaun
approved these changes
Jul 2, 2025
Planning to test it this week, with some changes planned. |
|
@ketanhwr this has become a blocker. Any updates on ETA? |
ketanhwr
force-pushed
the
ketan/internal-build
branch
from
a918b83 to
e15845c
Compare
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal build workflow is limited by the fact, that it needs a commit which belongs tocloudflare/workerdrepo. Commits in forks, unfortunately, do not belong in this repo - hence we need to create an internal branch which mirrors the fork branch and then call the internal build with the mirror branch instead.It turns out that it works across forks - some magic involved I'm sure.