Fix ruleset for the v5 provider
#851
Conversation
| @@ -480,6 +480,11 @@ func TestResourceGenerationV5(t *testing.T) { | |||
| Transport: r, | |||
| }, | |||
| )) | |||
| apiV0, _ = cfv0.New(viper.GetString("key"), viper.GetString("email"), cfv0.HTTPClient( | |||
There was a problem hiding this comment.
it looks like it assumes we're using API key + email for the old client. shouldn't it be initialising the same credentials we already have for the newer client?
There was a problem hiding this comment.
Yeah, that's just for the unit tests though, which in the V4 test, only uses the key/email auth scheme.
On this commit, there's a fix for API client initializations to be the same outside of test runs: f4c7fcc
| // The ruleset API has many gotchas that are accounted for in how we build | ||
| // the 'response' object that feeds into the HCL generation, and it's difficult | ||
| // to ensure the same compatability using the generated SDK. | ||
| useOldSDK := resourceType == "cloudflare_ruleset" |
There was a problem hiding this comment.
is it better copy the remapping logic instead of forcing this to use the old conditions?
There was a problem hiding this comment.
After a bit too much toiling, it appears so. Based on how we've built the V5 support in so far, I have to circumvent many assumptions we make about using the newer Go SDK. I thought this was the less bad option.
|
@musa-cf all the |
This uses the old SDK to assemble the combined rulesets and rules.
Closes #801