Remove validation from the string representation #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <[email protected]>
|
I think the tests are looking for that string. |
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
|
LGTM |
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 6, 2021
This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year old and catches us up quite far. There was one manual change in the cloud_event_controller_test.go file. CloudEvents changed the string representation of an event, which our tests looked for. This matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639. Signed-off-by: Dan Lorenc <[email protected]>
4 tasks
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 7, 2021
This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year old and catches us up quite far. There was one manual change in the cloud_event_controller_test.go file. CloudEvents changed the string representation of an event, which our tests looked for. This matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639. Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Dan Lorenc <[email protected]>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 15, 2021
This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year old and catches us up quite far. There was one manual change in the cloud_event_controller_test.go file. CloudEvents changed the string representation of an event, which our tests looked for. This matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639. Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Dan Lorenc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons for this change are:
Signed-off-by: Francesco Guardiani [email protected]