fix(dia.Paper): ensure grid pattern ids are unique #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geliogabalus
approved these changes
May 9, 2024
|
Hi team @kumilingus, may I ask when a new version will be released for this change, I'm currently using JointJS+ and I'm experiencing this problem. |
|
@tkaabbc we have just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2648
Description
Fix to generate unique ids for paper
<pattern/>elements to allow multiple paper instances draw a grid.By definition, element
idmust be unique within a single document.Because the pattern identifiers were unique within the paper instance (and not globally), only one of the grids was displayed.