Fix concurrent queue item handling (re #290) #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert changes from #294 and instead pass ConsumerDispatchConcurrency in SubscribeOptions. Use this to control concurrency and not the prefetch count otherwise that will create way too many tasks in the batch handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #290 is not quite right.
PrefetchCount!=ConsumerDispatchConcurrency. Prefetch count is how many messages to receive before you need to ack to get more.ConsumerDispatchConcurrencyis how many threads to run the messages on.If we set
ConsumerDispatchConcurrencytoPrefetchCountand prefetch count is large (ie when doing batches) then you'll be creating way too many threads.Instead, pass
ConsumerDispatchConcurrencyinSubscribeOptionsand use this to control concurrency and not thePrefetchCount