Skip to content

Conversation

speedytwenty
Copy link
Collaborator

This mocks the colors module within the "legacy tests" to produce consistent output from colors—as the tests expect.

This one-liner appropriately resolves #196.

@speedytwenty
Copy link
Collaborator Author

To emphasize, this failing test is not detected by CI (Travis nor Github Actions) but only by developers.

To verify this fix requires testing both the failing test and the passing test manually:

➭ git clone https://github.com/speedytwenty/cli-table3.git
➭ cd cli-table3
➭ yarn install --frozen-lockfile
➭ yarn test
➭ git checkout issue-196b
➭ yarn test

Use ➭ git checkout v0.6.0 to see the tests fail if testing after the fix hits master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing unit test

1 participant