chore(repo): Remove TanStack Router tests #6955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 378898b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis change removes the TanStack React Router integration template, its presets, configuration, and tests. CI/test matrices and build tooling references to this template are pruned. A changeset placeholder file is added. Public exports shrink where the tanstack preset no longer exposes reactRouter. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (19)
.changeset/empty-elephants-push.md(1 hunks).github/workflows/ci.yml(0 hunks)integration/presets/tanstack.ts(0 hunks)integration/templates/index.ts(0 hunks)integration/templates/tanstack-react-router/.gitignore(0 hunks)integration/templates/tanstack-react-router/README.md(0 hunks)integration/templates/tanstack-react-router/index.html(0 hunks)integration/templates/tanstack-react-router/package.json(0 hunks)integration/templates/tanstack-react-router/src/main.tsx(0 hunks)integration/templates/tanstack-react-router/src/routeTree.gen.ts(0 hunks)integration/templates/tanstack-react-router/src/routes/__root.tsx(0 hunks)integration/templates/tanstack-react-router/src/routes/index.tsx(0 hunks)integration/templates/tanstack-react-router/src/routes/sign-in.tsx(0 hunks)integration/templates/tanstack-react-router/tsconfig.dev.json(0 hunks)integration/templates/tanstack-react-router/tsconfig.json(0 hunks)integration/templates/tanstack-react-router/vite.config.js(0 hunks)integration/tests/tanstack-router/basic.test.ts(0 hunks)package.json(0 hunks)turbo.json(0 hunks)
💤 Files with no reviewable changes (18)
- integration/templates/tanstack-react-router/README.md
- turbo.json
- integration/templates/index.ts
- integration/tests/tanstack-router/basic.test.ts
- .github/workflows/ci.yml
- integration/presets/tanstack.ts
- package.json
- integration/templates/tanstack-react-router/tsconfig.json
- integration/templates/tanstack-react-router/tsconfig.dev.json
- integration/templates/tanstack-react-router/.gitignore
- integration/templates/tanstack-react-router/src/routes/__root.tsx
- integration/templates/tanstack-react-router/package.json
- integration/templates/tanstack-react-router/vite.config.js
- integration/templates/tanstack-react-router/src/main.tsx
- integration/templates/tanstack-react-router/src/routeTree.gen.ts
- integration/templates/tanstack-react-router/src/routes/sign-in.tsx
- integration/templates/tanstack-react-router/src/routes/index.tsx
- integration/templates/tanstack-react-router/index.html
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/empty-elephants-push.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
Comment on lines
+1
to
+2
| --- | ||
| --- |
There was a problem hiding this comment.
Fill in the changeset frontmatter and summary.
This changeset is empty—no packages are listed for bumping and there’s no summary. The Changesets pipeline will flag this (or ignore it entirely), so please add the appropriate package entries and a brief description before merging.
🤖 Prompt for AI Agents
In .changeset/empty-elephants-push.md around lines 1 to 2, the changeset
frontmatter is empty and there is no summary; populate the YAML frontmatter with
the packages to be bumped and their bump types (patch/minor/major) and add a
short summary paragraph describing the change. Ensure the file begins with ---,
includes entries like package-name: patch for each affected package, then a
summary section (one or two sentences) and closes with ---, so the changeset
pipeline can correctly detect and apply the version bumps.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We decided to not support TanStack Router apps with our TanStack Start SDK and they should be using our
@clerk/reactSDK for TanStack Router apps insteadSee the TanStack Start DX Guide for more info
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit