refactor(clerk-js): Update text/icon color usages pt1 #6697

alexcarpenter · 2025-09-03T15:04:12Z

Description

Update search icon color

BEFORE	AFTER

Update payment source icon color

BEFORE	AFTER

Update user preview text color

BEFORE	AFTER

Resolves USER-3367, USER-3368, USER-3369

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Style
- Updated search icon, payment source icon, and user preview secondary identifier to use theme-based muted colors for improved visual consistency and readability. No functional changes.
Chores
- Added changeset entry for a patch release documenting the UI color updates.

vercel · 2025-09-03T15:04:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
clerk-js-sandbox	Ready	Preview	Comment	Sep 5, 2025 3:40pm

changeset-bot · 2025-09-03T15:04:21Z

🦋 Changeset detected

Latest commit: 2db0a18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-09-03T15:04:32Z

Walkthrough

Styling updates apply theme-based muted foreground colors to icons in MembersSearch and PaymentSourceRow, and set secondary colorScheme for the secondary identifier in UserPreview. A changeset is added to publish these UI color tweaks as a patch.

Changes

Cohort / File(s)	Summary
UI color tweaks `packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearch.tsx`, `packages/clerk-js/src/ui/components/PaymentSources/PaymentSourceRow.tsx`, `packages/clerk-js/src/ui/elements/UserPreview.tsx`	Apply theme-muted color to search and payment source icons; set `colorScheme='secondary'` for user preview secondary identifier. No logic changes.
Release metadata `.changeset/petite-donkeys-leave.md`	Add patch changeset describing UI color updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective	Addressed	Explanation
USER-3367: Make search icon colorMutedForeground	✅
USER-3368: Make payment source icon colorMutedForeground	✅
USER-3369: Make userPreviewSecondaryIdentifier colorScheme secondary	✅

Poem

I nibble on commits with whiskers bright,
Tinting icons softly in muted light.
A secondary hue for names I see,
Payment and search now harmonize with glee.
Patch hops out—thump, thump—so spry,
Color-tuned carrots for every UI! 🥕✨

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch alexcarpenter/user-3361-compile-updates-for-breaking-changes-in-ui-components

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-09-03T15:07:38Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6697

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6697

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6697

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6697

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6697

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6697

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6697

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6697

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6697

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6697

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6697

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6697

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6697

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6697

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6697

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6697

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6697

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6697

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6697

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6697

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6697

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6697

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6697

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6697

commit: 2db0a18

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearch.tsx (1)
96-98: Localize the aria-label

Avoid hard-coded user-facing strings. Use the same localization key as the placeholder for the input’s aria-label.

Apply this diff:
-          aria-label='Search'
+          aria-label={t(localizationKeys('organizationProfile.membersPage.action__search'))}

🧹 Nitpick comments (2)

packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearch.tsx (1)
42-65: Clear the debounce timer on unmount

Minor: add cleanup to prevent late triggers if the component unmounts mid-debounce.

Apply this diff:
   function handleKeyUp() {
     if (debounceTimer.current) {
       clearTimeout(debounceTimer.current);
     }

     debounceTimer.current = setTimeout(() => {
       onQueryTrigger(value.trim());
     }, membersSearchDebounceMs);
   }
+
+  // Cleanup any pending debounce on unmount
+  useEffect(() => {
+    return () => {
+      if (debounceTimer.current) {
+        clearTimeout(debounceTimer.current);
+      }
+    };
+  }, []);
packages/clerk-js/src/ui/components/UserButton/SessionActions.tsx (1)
142-149: Hoist static theming helpers to module scope

Avoid re-creating these functions on each render; keeps prop references stable and can reduce child re-renders.

Apply this diff in-place:
-  const commonActionSx: ThemableCssProp = t => ({
-    color: t.colors.$colorForeground,
-  });
-
-  const commonActionIconSx: ThemableCssProp = t => ({
-    color: t.colors.$colorMutedForeground,
-  });
+  // hoisted to module scope (see added snippet below)
Add this at module scope (above the component):
// Module-scope theming helpers to keep stable references
const commonActionSx: ThemableCssProp = t => ({
  color: t.colors.$colorForeground,
});
const commonActionIconSx: ThemableCssProp = t => ({
  color: t.colors.$colorMutedForeground,
});

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2f3ec and df1abc7.

📒 Files selected for processing (4)

packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearch.tsx (1 hunks)
packages/clerk-js/src/ui/components/PaymentSources/PaymentSourceRow.tsx (1 hunks)
packages/clerk-js/src/ui/components/UserButton/SessionActions.tsx (3 hunks)
packages/clerk-js/src/ui/elements/UserPreview.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

packages/clerk-js/src/ui/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/clerk-js-ui.mdc)

packages/clerk-js/src/ui/**/*.{ts,tsx}: Element descriptors should always be camelCase
Use element descriptors in UI components to enable consistent theming and styling via appearance.elements
Element descriptors should generate unique, stable CSS classes for theming
Element descriptors should handle state classes (e.g., cl-loading, cl-active, cl-error, cl-open) automatically based on component state
Do not render hard-coded values; all user-facing strings must be localized using provided localization methods
Use the useLocalizations hook and localizationKeys utility for all text and error messages
Use the styled system (sx prop, theme tokens, responsive values) for custom component styling
Use useCardState for card-level state, useFormState for form-level state, and useLoadingStatus for loading states
Always use handleError utility for API errors and use translateError for localized error messages
Use useFormControl for form field state, implement proper validation, and handle loading and error states in forms
Use localization keys for all form labels and placeholders
Use element descriptors for consistent styling and follow the theme token system
Use the Card and FormContainer patterns for consistent UI structure

Files:

packages/clerk-js/src/ui/elements/UserPreview.tsx
packages/clerk-js/src/ui/components/PaymentSources/PaymentSourceRow.tsx
packages/clerk-js/src/ui/components/UserButton/SessionActions.tsx
packages/clerk-js/src/ui/components/OrganizationProfile/MembersSearch.tsx

**/*.{js,jsx,ts,tsx}