Add better support for cs-CZ localization (czech language) #6316
Conversation
|
|
@ToliaGuy is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe update completes the Czech localization file ( Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/localizations/src/cs-CZ.ts(5 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{js,jsx,ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
packages/**/*.{ts,tsx,d.ts}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/development.mdc
- .cursor/rules/typescript.mdc
packages/localizations/**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/monorepo.mdc
**/*
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (1)
📓 Common learnings
Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
packages/localizations/src/cs-CZ.ts (1)
205-208: Untranslated placeholder stillundefined
formFieldInputPlaceholder__usernameis left asundefined, so the UI will fall back to the default (English) text or render an empty string depending on runtime logic. Given the PR goal is “better support for cs-CZ”, please provide a Czech value or delete the key entirely to inherit the upstream default.- formFieldInputPlaceholder__username: undefined, + formFieldInputPlaceholder__username: 'Zadejte uživatelské jméno',
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/localizations/src/cs-CZ.ts (1)
15-15: Consider adding tests for localization coverageAccording to the coding guidelines, tests should be added to cover the changes. Consider adding tests to verify that:
- The Czech localization loads correctly
- Key lookups return the expected translated strings
- Placeholder interpolation works properly with Czech text
- Date and number formatting functions correctly with the Czech locale
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/localizations/src/cs-CZ.ts(5 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (2)
📓 Common learnings
Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.
Learnt from: ToliaGuy
PR: clerk/javascript#6316
File: packages/localizations/src/cs-CZ.ts:795-813
Timestamp: 2025-07-15T12:56:48.352Z
Learning: In Clerk's localization files, when keys are set to `undefined` in the base English localization (en-US.ts), translated files should maintain the same `undefined` status to ensure consistency. This is the correct approach rather than attempting to translate unused/placeholder keys.
packages/localizations/src/cs-CZ.ts (4)
Learnt from: ToliaGuy
PR: clerk/javascript#6316
File: packages/localizations/src/cs-CZ.ts:795-813
Timestamp: 2025-07-15T12:56:48.352Z
Learning: In Clerk's localization files, when keys are set to `undefined` in the base English localization (en-US.ts), translated files should maintain the same `undefined` status to ensure consistency. This is the correct approach rather than attempting to translate unused/placeholder keys.
Learnt from: CR
PR: clerk/javascript#0
File: .cursor/rules/monorepo.mdc:0-0
Timestamp: 2025-06-30T10:30:56.197Z
Learning: Applies to packages/{clerk-js,elements,themes}/**/* : Visual regression testing should be performed for UI components.
Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.
Learnt from: jacekradko
PR: clerk/javascript#5905
File: .changeset/six-ears-wash.md:1-3
Timestamp: 2025-06-26T03:27:05.535Z
Learning: In the Clerk JavaScript repository, changeset headers support single quotes syntax (e.g., '@clerk/backend': minor) and work fine with their current changesets integration, so there's no need to change them to double quotes.
🔇 Additional comments (4)
packages/localizations/src/cs-CZ.ts (4)
18-49: Excellent Czech translations for API keys sectionThe translations are accurate, maintain proper placeholders, and use appropriate Czech locale formatting for dates. The professional tone is consistent throughout.
70-161: Comprehensive and accurate commerce translationsThe financial and subscription-related translations are well-executed with proper Czech business terminology. Placeholder formatting for currencies, dates, and amounts is correctly preserved.
162-792: Well-structured authentication and organization management translationsThe translations for organization management and authentication flows are comprehensive and user-friendly. They maintain consistent formality and provide clear instructions for users navigating these critical features.
793-1248: Complete error handling and user profile translationsThe error messages and user profile management translations are thorough and appropriate. The undefined keys are correctly maintained to match the base English localization, as clarified in previous reviews.
There was a problem hiding this comment.
Hi @ToliaGuy, this looks great - thanks! Merging so we can get this out soon
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
3 participants
Description
Recently I have stumbled upon clerk and I love it. I am building a product for czech people, so I thought it would be useful
to add better localization for czech language.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Style