Skip to content

Add curation for com.apache.commons:commons-pool2 #29837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

lbourdages
Copy link
Contributor

@capfei
Copy link
Member

capfei commented Aug 1, 2025

@lbourdages Thank you for the contribution! 🎉

@capfei capfei merged commit 47a2657 into clearlydefined:master Aug 1, 2025
2 checks passed
@lbourdages lbourdages deleted the patch-1 branch August 1, 2025 17:16
@lbourdages
Copy link
Contributor Author

Hey @capfei,

Thanks for approving and merging this!

I do have a question though, I am very new to this process.

I've had a look at the definition here: https://clearlydefined.io/definitions/maven/mavencentral/org.apache.commons/commons-pool2/2.12.1

I can see my curation being applied, but it doesn't seem to have changed the declared license. Did I understand how curations work wrong? I thought this would completely override the harvested data.

Thanks!

@capfei
Copy link
Member

capfei commented Aug 1, 2025

@lbourdages Yes, it should have updated to Apache-2.0. Not sure why this happens sometimes. Thank you for letting me know. I'll see if I can get it to refresh.

@capfei
Copy link
Member

capfei commented Aug 4, 2025

@lbourdages I found the issue! The file was named incorrectly. Sorry I missed this! 😖

In your PR the file name was commons-pool-2.yaml.
I updated it to commons-pool2.yaml.

Renaming the file fixed the issue: https://clearlydefined.io/definitions/maven/mavencentral/org.apache.commons/commons-pool2/2.12.1/2.12.1

@lbourdages
Copy link
Contributor Author

@lbourdages I found the issue! The file was named incorrectly. Sorry I missed this! 😖

In your PR the file name was commons-pool-2.yaml. I updated it to commons-pool2.yaml.

Renaming the file fixed the issue: https://clearlydefined.io/definitions/maven/mavencentral/org.apache.commons/commons-pool2/2.12.1/2.12.1

Of course I had to make a typo! 🤦🏼

Thanks a lot for looking into this and making a fix, it is very much appreciated! 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants