-
Notifications
You must be signed in to change notification settings - Fork 2
Makemess pathlib #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: makemess_pathlib
Are you sure you want to change the base?
Makemess pathlib #10
Conversation
|
Thanks for trying to help, however something must be wrong in your method because the patch is way too big. |
I think, I did rebase from main branch of django in my PR branch. I'll update this one |
|
Hi @claudep, Try your branch rebase with latest changes of django main branch. It's showing your current branch head not on top. |
|
The fact that the branch is not on top should not prevent you to work with it. However, I just rebased now on main (but considering main is moving constantly ,it will quickly be behind again!) |
6ae91ca to
a00360f
Compare
Hi @claudep, Can you allow workflows awaiting approval? |
|
Looks like there is still some work to do! |
|
Hi @claudep , Please rebase your branch with Django main branch |
a00360f to
6e449fa
Compare
|
I rebased ans also included your "Fixed testcase" commit, but looks like tests are still failing on Windows. |
Can you allow workflow approval? I tested locally with the Windows system, there is no test case failing, I followed the same step as a workflow for windows and the same Python version but not getting any error in the windows system. |
|
You can check the Windows errors above. |
|
Hi @claudep , I updated the test case, Check and let me know if you have any confusion. Approve workflow to check code. |
Hi @claudep , working on your PR that you raised to django.