Skip to content

Conversation

@sainipray
Copy link

Hi @claudep , working on your PR that you raised to django.

@claudep
Copy link
Owner

claudep commented Aug 25, 2022

Thanks for trying to help, however something must be wrong in your method because the patch is way too big.

@sainipray
Copy link
Author

sainipray commented Aug 25, 2022

Thanks for trying to help, however something must be wrong in your method because the patch is way too big.

I think, I did rebase from main branch of django in my PR branch. I'll update this one

@sainipray
Copy link
Author

Hi @claudep, Try your branch rebase with latest changes of django main branch. It's showing your current branch head not on top.

@claudep
Copy link
Owner

claudep commented Aug 26, 2022

The fact that the branch is not on top should not prevent you to work with it. However, I just rebased now on main (but considering main is moving constantly ,it will quickly be behind again!)

@sainipray
Copy link
Author

The fact that the branch is not on top should not prevent you to work with it. However, I just rebased now on main (but considering main is moving constantly ,it will quickly be behind again!)

Hi @claudep, Can you allow workflows awaiting approval?

@claudep
Copy link
Owner

claudep commented Aug 26, 2022

Looks like there is still some work to do!

@sainipray
Copy link
Author

Hi @claudep , Please rebase your branch with Django main branch

@claudep
Copy link
Owner

claudep commented Sep 24, 2022

I rebased ans also included your "Fixed testcase" commit, but looks like tests are still failing on Windows.

@sainipray
Copy link
Author

I rebased ans also included your "Fixed testcase" commit, but looks like tests are still failing on Windows.

Can you allow workflow approval?

I tested locally with the Windows system, there is no test case failing, I followed the same step as a workflow for windows and the same Python version but not getting any error in the windows system.
I'll try again but approve workflows so I can check what's still issue

@claudep
Copy link
Owner

claudep commented Sep 27, 2022

You can check the Windows errors above.

@sainipray
Copy link
Author

Hi @claudep , I updated the test case, Check and let me know if you have any confusion. Approve workflow to check code.

@claudep claudep force-pushed the makemess_pathlib branch from 6e449fa to f198309 Compare July 5, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants