Skip to content

Legend should only initialize on first render #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chiil merged 1 commit into from
Oct 17, 2025
Merged

Legend should only initialize on first render #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions apps/class-solid/src/components/Analysis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,12 @@ export function TimeSeriesPlot({ analysis }: { analysis: TimeseriesAnalysis }) {
const [toggles, setToggles] = createStore<Record<string, boolean>>({});

// Initialize all lines as visible
createEffect(() => {
for (const d of chartData()) {
setToggles(d.label, true);
}
});
for (const d of chartData()) {
setToggles(d.label, true);
}

function toggleLine(label: string, value: boolean) {
console.log("toggleLine called");
setToggles(label, value);
}

Expand Down Expand Up @@ -334,11 +333,9 @@ export function VerticalProfilePlot({
const [toggles, setToggles] = createStore<Record<string, boolean>>({});

// Initialize all lines as visible
createEffect(() => {
for (const d of chartData()) {
setToggles(d.label, true);
}
});
for (const d of chartData()) {
setToggles(d.label, true);
}

function toggleLine(label: string, value: boolean) {
setToggles(label, value);
Expand Down
10 changes: 4 additions & 6 deletions apps/class-solid/src/components/plots/skewTlogP.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code modified from https://github.com/rsobash/d3-skewt/ (MIT license)
import * as d3 from "d3";
import { For, Show, createEffect, createSignal } from "solid-js";
import { For, Show, createSignal } from "solid-js";
import { createStore } from "solid-js/store";
import { AxisBottom, AxisLeft } from "./Axes";
import type { ChartData, SupportedScaleTypes } from "./ChartContainer";
Expand Down Expand Up @@ -180,11 +180,9 @@ export function SkewTPlot(props: {
props.data().filter((d) => !d.label.includes("- fire plume"));

// Initialize all lines as visible
createEffect(() => {
for (const d of dataForLegend()) {
setToggles(d.label, true);
}
});
for (const d of dataForLegend()) {
setToggles(d.label, true);
}

function toggleLine(label: string, value: boolean) {
setToggles(label, value);
Expand Down