fix G68, G69, add G50, G51 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerAndere1
force-pushed
the
rot_scale_squash
branch
from
d930f1d to
8de0440
Compare
DerAndere1
force-pushed
the
rot_scale_squash
branch
from
8de0440 to
68d503b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Parameter P. G68 and G51 apply to the active coordinate system and changing coordinate systems (G54...G59) requires rotation to be canceled with G69. This is how other controls handle these commands according to my research.
Requirements
ROTATE_WORKSPACE, SCALE_WORKSPACE
Benefits
Make G68 work as documented by Haas,
Add G51 scaling