fix(ValueEnum): Detailed help for ValueEnum variant #6096 #6101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Aug 11, 2025
|
Note that the intention of #6096 is not to add separate short vs long help (we only show any help in long help) but to change the derive from reporting the doc comment summary to the full doc comment. |
To clarify my understanding based on your last comment: help should render the full doc comment of a PossibleValue, right? I’m not sure how close (or far) my recent changes are from this goal. |
epage
reviewed
Aug 11, 2025
epage
reviewed
Aug 11, 2025
epage
reviewed
Aug 12, 2025
|
Could you clean up the commits for how this should be reviewed and merged? |
smoqadam
force-pushed
the
fix/value-enum-detailed-help
branch
from
cc012d2 to
9fdc172
Compare
epage
reviewed
Aug 12, 2025
epage
reviewed
Aug 12, 2025
epage
reviewed
Aug 12, 2025
smoqadam
force-pushed
the
fix/value-enum-detailed-help
branch
from
9fdc172 to
3225e5e
Compare
epage
force-pushed
the
fix/value-enum-detailed-help
branch
2 times, most recently
from
f28876d to
a8b8289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6096